[FIXED] Global variables as input parameters

Issue

I doubt whether it is appropriate to use input variables in functions in cases where the input variable will always be the same.

mynum = int(datetime.today().weekday())

def somefuncion():
    result = 3 + mynum
    return result

optionA = somefuncion()

def somefunction2(number):
    result = 3 + number
    return result

optionB = somefunction2(mynum)
  
print(optionA == optionB) # true

Is there good practice in this respect ? or is it indifferent ?

Solution

If you are sure that you are not going to modify the value of the variable anywhere in the code then you should declare it as a constant and use it that way within the code. i.e. not include it as an input variable.

Python, constants are capitalized (PEP 8 standards) which helps the programmer know it's a constant.

i.e

CONSTANT = "Whatever"

in your example:

MYNUM = int(datetime.today().weekday())

def somefuncion():
    result = 3 + MYNUM
    return result

Answered By - Cristian C